Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1426203002:
[Ozone] Enable AVS HQ mode (advanced video scaling) (Closed)
|
Created:
5 years, 1 month ago by william.xie1 Modified:
5 years, 1 month ago CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, seanvk, llandwerlin-old Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Ozone] Enables advanced video scaling
Curently video processing uses default scaling mode,
this CL changes it to AVS HQ mode to improve scaling quality.
BUG=None
TEST=BDW/auron, play h264 video on overlay, check the anti-alias improvement
Committed: https://crrev.com/72a9dd53969546b3ea6058b9bbbfce40cb926b83
Cr-Commit-Position: refs/heads/master@{#358263}
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
PTAL
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS mode to improve scaling quality. BUG=None ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS mode to improve scaling quality. BUG=None ==========
william.xie@intel.com changed reviewers: + posciak@chromium.org
@Pawel, PTAL
Please provide a TEST= line explaining how this was tested and on what platforms. Please also provide benchmark numbers before and after this change for ChromeOS platforms. Results from video_VDAPerf test for frame delivery time for 1080p and 4k h264 would be preferred. We had a bug when vpp operations had to be switched to fast mode, otherwise we had a major performance regression. So I'm concerned that this may bring back performance issues. https://chromium-review.googlesource.com/263824 addressed the issues then. Thank you.
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS mode to improve scaling quality. BUG=None ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None ==========
william.xie@intel.com changed reviewers: + sean.v.kelley@intel.com
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=Tested on BDW/auron platform, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement of image ==========
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=Tested on BDW/auron platform, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement of image ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=Tested on BDW/auron platform, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement of image ==========
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=Tested on BDW/auron platform, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement of image ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=BDW/auron, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement ==========
Description was changed from ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=BDW/auron, enable Ozone hardware overlay, play h264 video on overlay, check the anti-alias improvement ========== to ========== [Ozone] Enables advanced video scaling Curently video processing uses default scaling mode, this CL changes it to AVS HQ mode to improve scaling quality. BUG=None TEST=BDW/auron, play h264 video on overlay, check the anti-alias improvement ==========
On 2015/11/02 01:41:27, Pawel Osciak wrote: > Please provide a TEST= line explaining how this was tested and on what > platforms. > > Please also provide benchmark numbers before and after this change for ChromeOS > platforms. Results from video_VDAPerf test for frame delivery time for 1080p and > 4k h264 would be preferred. > > We had a bug when vpp operations had to be switched to fast mode, otherwise we > had a major performance regression. So I'm concerned that this may bring back > performance issues. https://chromium-review.googlesource.com/263824 addressed > the issues then. > > Thank you. Dear Pawel, Below is the perf_measurements from video_VDAPerf, just let me know if need more. Before the CL: {"description": "crowd1080_h264.delivery_time.percentile_0.75", "graph": null, "higher_is_better": false, "units": "us", "value": 4971.0} {"description": "crowd1080_h264.delivery_time.percentile_0.50", "graph": null, "higher_is_better": false, "units": "us", "value": 4015.0} {"description": "crowd1080_h264.delivery_time.percentile_0.25", "graph": null, "higher_is_better": false, "units": "us", "value": 2811.75} {"description": "crowd2160_h264.delivery_time.percentile_0.75", "graph": null, "higher_is_better": false, "units": "us", "value": 20339.75} {"description": "crowd2160_h264.delivery_time.percentile_0.50", "graph": null, "higher_is_better": false, "units": "us", "value": 15828.0} {"description": "crowd2160_h264.delivery_time.percentile_0.25", "graph": null, "higher_is_better": false, "units": "us", "value": 9630.75} After the CL: {"description": "crowd1080_h264.delivery_time.percentile_0.75", "graph": null, "higher_is_better": false, "units": "us", "value": 4996.25} {"description": "crowd1080_h264.delivery_time.percentile_0.50", "graph": null, "higher_is_better": false, "units": "us", "value": 4007.0} {"description": "crowd1080_h264.delivery_time.percentile_0.25", "graph": null, "higher_is_better": false, "units": "us", "value": 2723.0} {"description": "crowd2160_h264.delivery_time.percentile_0.75", "graph": null, "higher_is_better": false, "units": "us", "value": 20478.0} {"description": "crowd2160_h264.delivery_time.percentile_0.50", "graph": null, "higher_is_better": false, "units": "us", "value": 15889.5} {"description": "crowd2160_h264.delivery_time.percentile_0.25", "graph": null, "higher_is_better": false, "units": "us", "value": 9713.75}
AVS is enabled by default on GEN 7+ platforms. However, it is not supported on GEN6 (SNB). What you are doing is applying the HQ 8-tap filter flag. In the case of GEN6, this has no effect. You should test with a SNB for completeness in addition to the GEN7+ platforms.
On 2015/11/03 21:47:01, seanvk wrote: > AVS is enabled by default on GEN 7+ platforms. However, it is not supported on > GEN6 (SNB). What you are doing is applying the HQ 8-tap filter flag. In the > case of GEN6, this has no effect. You should test with a SNB for completeness > in addition to the GEN7+ platforms. Thanks Sean, Per media QA's testing, there is no impact/regression with this flag on SNB platform.
On 2015/11/04 04:37:01, william.xie wrote: > On 2015/11/03 21:47:01, seanvk wrote: > > AVS is enabled by default on GEN 7+ platforms. However, it is not supported > on > > GEN6 (SNB). What you are doing is applying the HQ 8-tap filter flag. In the > > case of GEN6, this has no effect. You should test with a SNB for completeness > > in addition to the GEN7+ platforms. > > Thanks Sean, > Per media QA's testing, there is no impact/regression with this flag on SNB > platform. Thank you very much for the perf numbers. Looks like we don't have any perf regressions with this, which is great. If it would be a no-op on SNB, then we should be ok there as well. Sean, if you are ok with this change, please indicate so and I will approve. Thanks.
lgtm
lgtm
The CQ bit was checked by posciak@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426203002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by william.xie@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426203002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/72a9dd53969546b3ea6058b9bbbfce40cb926b83 Cr-Commit-Position: refs/heads/master@{#358263} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
