Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: printing/printing.gyp

Issue 14262006: Disable deprecation warnings for CUPS as the compile fails when using CUPS 1.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing.gyp
diff --git a/printing/printing.gyp b/printing/printing.gyp
index 8490a03b3fcd89b6c64bf22c2554a84dbf04b816..3928e4c5739564ffc6f378ef7a6fcfdf754ddd8a 100644
--- a/printing/printing.gyp
+++ b/printing/printing.gyp
@@ -162,12 +162,23 @@
'dependencies': [
'cups',
],
+ 'variables': {
+ 'cups_version': '<!(cups-config --api-version)',
+ },
'conditions': [
['OS!="mac"', {
'dependencies': [
'../build/linux/system.gyp:libgcrypt',
],
}],
+ ['cups_version=="1.6"', {
+ 'cflags': [
+ # CUPS 1.6 deprecated the PPD APIs, but we will stay with this API
Lei Zhang 2013/04/15 23:00:47 Can you wrap at 80 lines? We try to when possible.
+ # for now as supported Linux and Mac OS'es are still using older
+ # versions of CUPS.
+ '-Wno-deprecated-declarations',
+ ],
+ }],
],
'defines': [
# PRINT_BACKEND_AVAILABLE disables the default dummy implementation
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698