Issue 1426173002: Use HSL in generation of trace viewer color scheme

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1426173002: Use HSL in generation of trace viewer color scheme (Closed)

Created:
5 years, 1 month ago by nduca

Modified:
5 years, 1 month ago

Reviewers:
beaudoin

CC:
catapult-reviews_chromium.org, tracing-review_chromium.org

Base URL:
https://github.com/catapult-project/catapult.git@master

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

More Reviews

Description

Use HSL in generation of trace viewer color scheme This switches us from the hacky brightening algoirthms to HSL-based boosting. This improves the consistency of brigtening: previously, some colors got brighter than others. Now, things should brigten more uniformly. TBR=beaudoin BUG=#1117 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9fbe09d8382416857954deb40e8d655d57445b64

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -69 lines)			Patch
M	tracing/tracing/base/color.html	View	4 chunks	+10 lines, -31 lines	0 comments	Download
M	tracing/tracing/base/color_scheme.html	View	2 chunks	+30 lines, -31 lines	0 comments	Download
M	tracing/tracing/base/color_scheme_test.html	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426173002/1

5 years, 1 month ago (2015-10-31 14:22:47 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-10-31 14:29:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages