port remoting_me2me_host_archive to GN

port remoting_me2me_host_archive to GN

This CL ports the remoting_me2me_host_archive target to GN and several
of its dependent targets. This is only a partial port of the target, as
the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm
not actually sure if that's needed on Linux.

This CL also fixes the path to the remoting-webapp zip file.

Both of these targets were needed in order to flip the official
Linux x64 build over to GN.

BUG=512899, 530733
Committed: https://crrev.com/63e164a242653dbed7932fe9213da828aa280f78
Cr-Commit-Position: refs/heads/master@{#357697}

[Dirk Pranke, 2015-11-03 03:09:50]

Description was changed from

==========
checkpoint work on remoting host linux archive.

BUG=
==========

to

==========
port remoting_me2me_host_archive to GN

This CL ports the remoting_me2me_host_archive target to GN and several
of its dependent targets. This is only a partial port of the target, as
the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm
not actually sure if that's needed on Linux.

This CL also fixes the path to the remoting-webapp zip file.

Both of these targets were needed in order to flip the official Linux x64 build
over to GN.

BUG=512899, 530733
==========

[Dirk Pranke, 2015-11-03 03:09:50]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org, sergeyu@chromium.org

[Dirk Pranke, 2015-11-03 03:11:09]

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:622: action("remoting_me2me_host_deb_installer") {
there's something wonky going on in this target that causes it to always be out
of date. I haven't figured out what's going on with this yet, but since it's
only built in an official build it's probably okay to figure this out in a
follow-up CL if the rest of this patch seems okay.

[Dirk Pranke, 2015-11-03 03:11:22]

Description was changed from

==========
port remoting_me2me_host_archive to GN

This CL ports the remoting_me2me_host_archive target to GN and several
of its dependent targets. This is only a partial port of the target, as
the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm
not actually sure if that's needed on Linux.

This CL also fixes the path to the remoting-webapp zip file.

Both of these targets were needed in order to flip the official Linux x64 build
over to GN.

BUG=512899, 530733
==========

to

==========
port remoting_me2me_host_archive to GN

This CL ports the remoting_me2me_host_archive target to GN and several
of its dependent targets. This is only a partial port of the target, as
the 'remoting_infoplist_strings' target hasn't been ported yet, but I'm
not actually sure if that's needed on Linux.

This CL also fixes the path to the remoting-webapp zip file.

Both of these targets were needed in order to flip the official 
Linux x64 build over to GN.

BUG=512899, 530733
==========

[Sergey Ulanov, 2015-11-03 18:21:37]

The only problem I see is that build-deb.sh needs to be fixed not to assume -
that's the build is in out/Release. I'll try fixing it ASAP.

https://codereview.chromium.org/1426113002/diff/40001/build/util/version.gni
File build/util/version.gni (right):

https://codereview.chromium.org/1426113002/diff/40001/build/util/version.gni#...
build/util/version.gni:29: # The
Finish the comment or remove it.

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:638: "installer/linux/build-deb.sh",
This script assumes that the output is always in out/Release and I don't think
it will work with from any other build directory. This shouldn't be hard to fix.
Do you plan to use out/Release on buildbots?

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/installer...
File remoting/host/installer/linux/build_deb.py (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/installer...
remoting/host/installer/linux/build_deb.py:1: # Copyright (c) 2015 The Chromium
Authors. All rights reserved.
nit: remove (c)

https://codereview.chromium.org/1426113002/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:40: pexe_dir = get_label_info(
I don't think you need this. desktop_remoting_webapp() template builds the pexe
file (see remoting/webapp/build_template.gni). Just remove the TODO.

[Sergey Ulanov, 2015-11-03 20:00:23]

On 2015/11/03 18:21:37, Sergey Ulanov wrote:
> The only problem I see is that build-deb.sh needs to be fixed not to assume -
> that's the build is in out/Release. I'll try fixing it ASAP.

This will be fixed with this CL https://codereview.chromium.org/1412653005/

[Dirk Pranke, 2015-11-03 21:10:20]

https://codereview.chromium.org/1426113002/diff/40001/build/util/version.gni
File build/util/version.gni (right):

https://codereview.chromium.org/1426113002/diff/40001/build/util/version.gni#...
build/util/version.gni:29: # The
On 2015/11/03 18:21:37, Sergey Ulanov wrote:
> Finish the comment or remove it.

Whoops. I will remove it. Good catch.

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:638: "installer/linux/build-deb.sh",
On 2015/11/03 18:21:37, Sergey Ulanov wrote:
> This script assumes that the output is always in out/Release and I don't think
> it will work with from any other build directory. This shouldn't be hard to
fix.
> Do you plan to use out/Release on buildbots?

The bots use out/Release and that probably won't change any time soon (there's
all sorts of places where that's hard-coded), but it would be good to fix the
issue anyway.

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/installer...
File remoting/host/installer/linux/build_deb.py (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/host/installer...
remoting/host/installer/linux/build_deb.py:1: # Copyright (c) 2015 The Chromium
Authors. All rights reserved.
On 2015/11/03 18:21:37, Sergey Ulanov wrote:
> nit: remove (c)

Will do.

https://codereview.chromium.org/1426113002/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:40: pexe_dir = get_label_info(
On 2015/11/03 18:21:37, Sergey Ulanov wrote:
> I don't think you need this. desktop_remoting_webapp() template builds the
pexe
> file (see remoting/webapp/build_template.gni). Just remove the TODO.

So it does. Will fix.

[Sergey Ulanov, 2015-11-03 22:25:44]

lgtm when my comments are addressed

[Dirk Pranke, 2015-11-03 23:41:53]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-11-03 23:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1426113002/#ps60001
(title: "update w/ review feedback")

[commit-bot: I haz the power, 2015-11-03 23:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426113002/60001

[commit-bot: I haz the power, 2015-11-03 23:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 23:51:33]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Dirk Pranke, 2015-11-04 00:02:44]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-11-04 00:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1426113002/#ps80001
(title: "import chrome_build.gni in remoting_options.gni")

[commit-bot: I haz the power, 2015-11-04 00:06:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1426113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1426113002/80001

[commit-bot: I haz the power, 2015-11-04 01:12:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-04 01:14:37]

Patchset 5 (id:??) landed as
https://crrev.com/63e164a242653dbed7932fe9213da828aa280f78
Cr-Commit-Position: refs/heads/master@{#357697}

[Sergey Ulanov, 2015-11-04 06:59:32]

https://codereview.chromium.org/1426113002/diff/80001/remoting/BUILD.gn
File remoting/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/80001/remoting/BUILD.gn#newco...
remoting/BUILD.gn:67: "//remoting/host:remoting_me2me_host_archive",
when looking again at this, this doesn't look quite right: this target is
defined only for the case is_chrome_branded=true

[Dirk Pranke, 2015-11-05 01:24:06]

https://codereview.chromium.org/1426113002/diff/80001/remoting/BUILD.gn
File remoting/BUILD.gn (right):

https://codereview.chromium.org/1426113002/diff/80001/remoting/BUILD.gn#newco...
remoting/BUILD.gn:67: "//remoting/host:remoting_me2me_host_archive",
On 2015/11/04 06:59:32, Sergey Ulanov wrote:
> when looking again at this, this doesn't look quite right: this target is
> defined only for the case is_chrome_branded=true

Ah, you're right. Will fix.