Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1426103004: bin/deps-and-gyp: gclient-free solution (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

bin/deps-and-gyp: gclient-free solution Committed: https://skia.googlesource.com/skia/+/0575131e579641e76798e58a8bb6786f9eebd5f2

Patch Set 1 : 2015-11-03 (Tuesday) 13:07:55 EST #

Patch Set 2 : 2015-11-03 (Tuesday) 13:12:58 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
A + bin/deps-and-gyp View 1 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hal.canary
PTAL Also, please test this out.
5 years, 1 month ago (2015-11-03 18:10:09 UTC) #5
mtklein
lgtm lgtm, will test it live.
5 years, 1 month ago (2015-11-03 18:16:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426103004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426103004/80001
5 years, 1 month ago (2015-11-03 18:16:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:80001) as https://skia.googlesource.com/skia/+/0575131e579641e76798e58a8bb6786f9eebd5f2
5 years, 1 month ago (2015-11-03 18:30:08 UTC) #9
mtklein
5 years, 1 month ago (2015-11-03 19:14:33 UTC) #10
Message was sent while issue was closed.
On 2015/11/03 at 18:30:08, commit-bot wrote:
> Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/0575131e579641e76798e58a8bb6786f9eebd5f2

~/skia (master) $ time sh bin/deps-and-gyp
GYP_GENERATORS is "ninja"
Updating projects from gyp files...
       37.25 real        60.88 user        33.53 sys
~/skia (master) $ time sh bin/deps-and-gyp
        0.34 real         0.09 user         0.12 sys

LGTM!

Powered by Google App Engine
This is Rietveld 408576698