XFA: Take CTTFontDesc::ReleaseFace() changes from master.

XFA: Take CTTFontDesc::ReleaseFace() changes from master.

Return true if object destroyed. Also get rid of
FXFT_Done_Face() call not present on master.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/fbc32aab95fff194bfc5d3f1cd733c4e418aeb09

[Tom Sepez, 2015-10-30 00:14:49]

Description was changed from

==========
XFA: Take CTTFontDesc::ReleaseFace() changes from master.

Return true if object destroyed.
==========

to

==========
XFA: Take CTTFontDesc::ReleaseFace() changes from master.

Return true if object destroyed. Also get rid of FXFT_Done_Face()
call not present on master.
==========

[Tom Sepez, 2015-10-30 00:14:49]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-30 00:15:50]

Description was changed from

==========
XFA: Take CTTFontDesc::ReleaseFace() changes from master.

Return true if object destroyed. Also get rid of FXFT_Done_Face()
call not present on master.
==========

to

==========
XFA: Take CTTFontDesc::ReleaseFace() changes from master.

Return true if object destroyed. Also get rid of
FXFT_Done_Face() call not present on master.
==========

[Tom Sepez, 2015-10-30 00:19:18]

Lei, for review.

[Lei Zhang, 2015-10-30 06:35:47]

lgtm

https://codereview.chromium.org/1426103002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (left):

https://codereview.chromium.org/1426103002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:372: if (bNeedFaceDone &&
!m_pBuiltinMapper->IsBuiltinFace(face)) {
CFX_FontMapper::IsBuiltinFace() is dead after this.

https://codereview.chromium.org/1426103002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:373: FXFT_Done_Face(face);
Better to leak than double free.

[Tom Sepez, 2015-10-30 19:45:36]

Committed patchset #1 (id:1) manually as
fbc32aab95fff194bfc5d3f1cd733c4e418aeb09 (presubmit successful).