Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14261008: Cancel any modal UI shown by the RDP control. (Closed)

Created:
7 years, 8 months ago by alexeypa (please no reviews)
Modified:
7 years, 8 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Cancel any modal UI shown by the RDP control. |RdpClientWindow| now installs WH_CBT hook to listen to window activations and closes any windows activated on the UI thread. This allows |RdpClientWindow| to cancel modal UI dialogs popped up by the RDP control. BUG=137696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194376

Patch Set 1 #

Total comments: 8

Patch Set 2 : CR feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -6 lines) Patch
M remoting/host/win/rdp_client_window.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M remoting/host/win/rdp_client_window.cc View 1 4 chunks +98 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL
7 years, 8 months ago (2013-04-15 18:12:05 UTC) #1
garykac
lgtm https://codereview.chromium.org/14261008/diff/1/remoting/host/win/rdp_client_window.cc File remoting/host/win/rdp_client_window.cc (right): https://codereview.chromium.org/14261008/diff/1/remoting/host/win/rdp_client_window.cc#newcode26 remoting/host/win/rdp_client_window.cc:26: // Points to a per-thread instance of the ...
7 years, 8 months ago (2013-04-15 18:23:49 UTC) #2
alexeypa (please no reviews)
https://codereview.chromium.org/14261008/diff/1/remoting/host/win/rdp_client_window.cc File remoting/host/win/rdp_client_window.cc (right): https://codereview.chromium.org/14261008/diff/1/remoting/host/win/rdp_client_window.cc#newcode26 remoting/host/win/rdp_client_window.cc:26: // Points to a per-thread instance of the window ...
7 years, 8 months ago (2013-04-15 18:26:53 UTC) #3
alexeypa (please no reviews)
7 years, 8 months ago (2013-04-16 17:03:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r194376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698