Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 14261002: Make generator function data path more clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: revised Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index dbda8ce06d93d8b497f78423b2a48ab5d5a77e05..d2a580fef189f4bfa6892a4258a7c8136b9be311 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -202,6 +202,30 @@ static v8::Persistent<v8::FunctionTemplate> ConfigureV8TestEventTargetTemplate(v
return desc;
}
+v8::Handle<v8::Value> V8TestEventTarget::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
+{
+ if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
+ return v8Undefined();
+ if (info.Holder()->HasRealNamedCallbackProperty(name))
+ return v8Undefined();
+
+ v8::Local<v8::Object> object = info.Holder();
+ v8::Handle<v8::Object> creationContext = info.Holder();
+ v8::Isolate* isolate = info.GetIsolate();
+
+ ASSERT(V8DOMWrapper::maybeDOMWrapper(object));
+ ASSERT(toWrapperTypeInfo(object) != &V8Node::info);
+ TestEventTarget* collection = toNative(object);
+
+ AtomicString propertyName = toWebCoreAtomicStringWithNullCheck(name);
+ RefPtr<Node> element = collection->namedItem(propertyName);
+
+ if (!element)
+ return v8Undefined();
+
+ return toV8(element.release(), creationContext, isolate);
+}
+
v8::Persistent<v8::FunctionTemplate> V8TestEventTarget::GetTemplate(v8::Isolate* isolate, WrapperWorldType currentWorldType)
{
V8PerIsolateData* data = V8PerIsolateData::from(isolate);
@@ -233,29 +257,6 @@ EventTarget* V8TestEventTarget::toEventTarget(v8::Handle<v8::Object> object)
return toNative(object);
}
-v8::Handle<v8::Value> V8TestEventTarget::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
- return v8Undefined();
- if (info.Holder()->HasRealNamedCallbackProperty(name))
- return v8Undefined();
-
- v8::Local<v8::Object> object = info.Holder();
- v8::Handle<v8::Object> creationContext = info.Holder();
- v8::Isolate* isolate = info.GetIsolate();
-
- ASSERT(V8DOMWrapper::maybeDOMWrapper(object));
- ASSERT(toWrapperTypeInfo(object) != &V8Node::info);
- TestEventTarget* collection = toNative(object);
-
- AtomicString propertyName = toWebCoreAtomicStringWithNullCheck(name);
- RefPtr<Node> element = collection->namedItem(propertyName);
-
- if (!element)
- return v8Undefined();
-
- return toV8(element.release(), creationContext, isolate);
-}
v8::Handle<v8::Object> V8TestEventTarget::createWrapper(PassRefPtr<TestEventTarget> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
« Source/bindings/scripts/CodeGeneratorV8.pm ('K') | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698