Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1426043002: Revert "Web Socket compression - take two" (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
butlermatt, Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Web Socket compression - take two" This reverts commit 59bb84127b63a7516a32a32eae6a6839420709db. A number of observatory tests broke. TBR=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d1e01e205a615257ba9391cb531ad8b053af1fed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -811 lines) Patch
M sdk/lib/io/http.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 8 chunks +7 lines, -26 lines 0 comments Download
M sdk/lib/io/websocket.dart View 9 chunks +14 lines, -168 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 30 chunks +241 lines, -442 lines 0 comments Download
D tests/standalone/io/web_socket_compression_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
M tests/standalone/io/web_socket_typed_data_test.dart View 9 chunks +15 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Søren Gjesse
5 years, 1 month ago (2015-10-29 13:13:15 UTC) #2
Søren Gjesse
Committed patchset #1 (id:1) manually as d1e01e205a615257ba9391cb531ad8b053af1fed (presubmit successful).
5 years, 1 month ago (2015-10-29 13:13:29 UTC) #3
Bill Hesse
5 years, 1 month ago (2015-10-29 13:13:50 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698