Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 14260013: Detect truncating Phi uses of Phis with constant inputs (Closed)

Created:
7 years, 7 months ago by Jakob Kummerow
Modified:
7 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, danno
Visibility:
Public.

Description

Detect truncating Phi uses of Phis with constant inputs Committed: http://code.google.com/p/v8/source/detail?r=14525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M src/hydrogen.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Michael: Please take a look. Danno: Just FYI since this is a follow-up to https://codereview.chromium.org/14471034/ ...
7 years, 7 months ago (2013-04-29 11:28:55 UTC) #1
Michael Starzinger
LGTM.
7 years, 7 months ago (2013-05-02 13:12:31 UTC) #2
Jakob Kummerow
7 years, 7 months ago (2013-05-02 16:31:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698