XFA: remove unsafe exif parsing code

XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
use of the CFX_/IFX_DIBAttributeEx class is as a table, so
put one directly in the CFX_DIBAttribute.

Fix a "register" warning along the way.

R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/83488a802d3e6f02faad6accbc17aa5da5795e63

[Tom Sepez, 2015-10-28 21:58:23]

Description was changed from

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
of the CFX_/IFX_DIBAttributeEx class is as a table, so put
that directly in the CFX_DIBAttribute struct.
==========

to

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
of the CFX_/IFX_DIBAttributeEx class is as a table, so put
that directly in the CFX_DIBAttribute struct.
==========

[Tom Sepez, 2015-10-28 21:58:23]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-10-28 21:58:33]

Description was changed from

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
of the CFX_/IFX_DIBAttributeEx class is as a table, so put
that directly in the CFX_DIBAttribute struct.
==========

to

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
of the CFX_/IFX_DIBAttributeEx class is as a table, so put
that directly in the CFX_DIBAttribute.
==========

[Tom Sepez, 2015-10-28 22:00:33]

Lei, Dan, for review.

[Tom Sepez, 2015-10-28 22:03:02]

Description was changed from

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
of the CFX_/IFX_DIBAttributeEx class is as a table, so put
that directly in the CFX_DIBAttribute.
==========

to

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
use of the CFX_/IFX_DIBAttributeEx class is as a table, so
put one directly in the CFX_DIBAttribute.
==========

[Tom Sepez, 2015-10-28 22:10:30]

Description was changed from

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
use of the CFX_/IFX_DIBAttributeEx class is as a table, so
put one directly in the CFX_DIBAttribute.
==========

to

==========
XFA: remove unsafe exif parsing code

Fortunately, this could only be called with a null buffer,
so none of unchecked lengths could be used.  The remaining
use of the CFX_/IFX_DIBAttributeEx class is as a table, so
put one directly in the CFX_DIBAttribute.

Fix a "register" warning along the way.
==========

[Tom Sepez, 2015-10-28 22:10:51]

https://codereview.chromium.org/1425983002/diff/1/core/src/fxcodec/codec/fx_c...
File core/src/fxcodec/codec/fx_codec_tiff.cpp (right):

https://codereview.chromium.org/1425983002/diff/1/core/src/fxcodec/codec/fx_c...
core/src/fxcodec/codec/fx_codec_tiff.cpp:273: void Tiff_Exif_GetStringInfo(TIFF*
tif_ctx,
note: follow-up - make this a char* specialization if any of this survives.

[dsinclair, 2015-10-29 02:10:02]

lgtm

[Tom Sepez, 2015-10-29 16:51:09]

Committed patchset #2 (id:20001) manually as
83488a802d3e6f02faad6accbc17aa5da5795e63 (presubmit successful).