Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2001)

Unified Diff: cc/scheduler/scheduler_state_machine.h

Issue 1425973003: cc: Don't attempt main thread synchronization if it is slow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on 1415763008; existing tests pass; new tests needed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_state_machine.h
diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h
index 17fdf988ee38fd7a0e95e74dcc4edbd0048e120c..7d885c1b8fdb3132a1444c0a25c9b63559461453 100644
--- a/cc/scheduler/scheduler_state_machine.h
+++ b/cc/scheduler/scheduler_state_machine.h
@@ -193,10 +193,15 @@ class CC_EXPORT SchedulerStateMachine {
// Indicates whether to prioritize impl thread latency (i.e., animation
// smoothness) over new content activation.
- void SetImplLatencyTakesPriority(bool impl_latency_takes_priority);
- bool impl_latency_takes_priority() const {
- return impl_latency_takes_priority_;
- }
+ void SetSmoothnessMode(bool smoothness_takes_priority,
+ bool scroll_affects_scroll_handler);
+
+ // Indicates if the main thread will likely respond within 1 vsync.
+ void SetCriticalBeginMainFrameToActivateIsFast(bool is_fast);
+
+ // A function of SetSmoothnessMode and
+ // SetCriticalBeginMainFrameToActivateIsFast.
+ bool ImplLatencyTakesPriority() const;
// Indicates whether ACTION_DRAW_AND_SWAP_IF_POSSIBLE drew to the screen.
void DidDrawIfPossibleCompleted(DrawResult result);
@@ -333,7 +338,9 @@ class CC_EXPORT SchedulerStateMachine {
bool pending_tree_is_ready_for_activation_;
bool active_tree_needs_first_draw_;
bool did_create_and_initialize_first_output_surface_;
- bool impl_latency_takes_priority_;
+ bool smoothness_takes_priority_;
+ bool scroll_affects_scroll_handler_;
+ bool critical_begin_main_frame_to_activate_is_fast_;
bool main_thread_missed_last_deadline_;
bool skip_next_begin_main_frame_to_reduce_latency_;
bool children_need_begin_frames_;

Powered by Google App Engine
This is Rietveld 408576698