Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1425943002: Revert of Fix WebGL 2 texture renderability check. (Closed)

Created:
5 years, 1 month ago by Jamie Madill
Modified:
5 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix WebGL 2 texture renderability check. (patchset #8 id:140001 of https://codereview.chromium.org/1412883002/ ) Reason for revert: Failing on several configs, possibly has a bug: On Windows, triggers a bug in ANGLE, should have a skip suppression: http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/11345 (assert in Renderer11.cpp in Debug) On Mac, fails for unknown reasons: http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%20%28ATI%29/builds/5643 http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.9%20Debug%20%28Intel%29/builds/21206 On Linux AMD, fails as well: http://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/42849 Original issue's description: > Fix WebGL 2 texture renderability check. > > It should check from base_level and up, not 0 and up. > > BUG=429053 > TEST=conformance2/textures/misc/tex-mipmap-levels.html, gpu_unittests > R=bajones@chromium.org,kbr@chromium.org > > Committed: https://crrev.com/493f20d34a57ae22da78f798235881ff39465ae0 > Cr-Commit-Position: refs/heads/master@{#356475} TBR=bajones@chromium.org,kbr@chromium.org,sievers@chromium.org,piman@chromium.org,qiankun.miao@intel.com,zmo@google.com,zmo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429053 Committed: https://crrev.com/96713d46c7291a773362015d1344b140c7711631 Cr-Commit-Position: refs/heads/master@{#356550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -147 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 3 chunks +3 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 16 chunks +35 lines, -81 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 3 chunks +7 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie Madill
Created Revert of Fix WebGL 2 texture renderability check.
5 years, 1 month ago (2015-10-28 14:26:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425943002/1
5 years, 1 month ago (2015-10-28 14:26:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 14:27:22 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 14:28:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96713d46c7291a773362015d1344b140c7711631
Cr-Commit-Position: refs/heads/master@{#356550}

Powered by Google App Engine
This is Rietveld 408576698