Issue 142593004: Revert of IDL compiler: sync Python to r165262

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142593004: Revert of IDL compiler: sync Python to r165262 (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert of IDL compiler: sync Python to r165262 (https://codereview.chromium.org/138033017/) Reason for revert: Underlying Perl change reverted; sync Python Perl revert in r165372 Revert of Add use counters for using Attrs as Nodes. https://codereview.chromium.org/130703003/ Original issue's description: > IDL compiler: sync Python to r165262 > > Python side to: > Add use counters for using Attrs as Nodes. > https://codereview.chromium.org/127723002 > > There are other cases (for interface Node itself), which I'll handle > when finalizing Node.idl. > > BUG=239771 > TBR=haraken > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165266 TBR=haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165373

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -14 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/bindings/scripts/unstable/v8_methods.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/templates/attributes.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/bindings/templates/methods.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

Created Revert of IDL compiler: sync Python to r165262

6 years, 11 months ago (2014-01-20 01:25:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/142593004/1

6 years, 11 months ago (2014-01-20 01:25:21 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages