third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h - Issue 1425913004: [SVG] Shared <use> path geometry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

Issue 1425913004: [SVG] Shared <use> path geometry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

index a351fec03e5e563557281f2c0a577f4c02167ac8..26a836537c13bf616ad55059be80f65e7bb84ee9 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h

@@ -130,6 +130,9 @@ private:

private:

OwnPtr<AffineTransform> m_localTransform;

+ // TODO(fmalita): the Path is now cached in SVGPath; while this additional cache is just a

+ // shallow copy, it certainly has a complexity/state management cost (plus allocation & storage

+ // overhead) - so we should look into removing it.

OwnPtr<Path> m_path;

mutable OwnPtr<LayoutSVGShapeRareData> m_rareData;