Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: test/unittests/compiler/js-builtin-reducer-unittest.cc

Issue 1425883004: [turbofan] Fix missing bailout point before calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update unittests. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | test/unittests/compiler/js-context-relaxation-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-builtin-reducer-unittest.cc
diff --git a/test/unittests/compiler/js-builtin-reducer-unittest.cc b/test/unittests/compiler/js-builtin-reducer-unittest.cc
index a44b1d18cd63fd6db613f062ce607920fba36be4..96cf5f4df8034e4d66c9902db9a273f07966c9dd 100644
--- a/test/unittests/compiler/js-builtin-reducer-unittest.cc
+++ b/test/unittests/compiler/js-builtin-reducer-unittest.cc
@@ -85,12 +85,13 @@ TEST_F(JSBuiltinReducerTest, MathMax0) {
Node* effect = graph()->start();
Node* control = graph()->start();
+ Node* context = UndefinedConstant();
Node* frame_state = graph()->start();
TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
Node* call = graph()->NewNode(
javascript()->CallFunction(2, NO_CALL_FUNCTION_FLAGS, language_mode),
- function, UndefinedConstant(), frame_state, frame_state, effect,
- control);
+ function, UndefinedConstant(), context, frame_state, frame_state,
+ effect, control);
Reduction r = Reduce(call);
ASSERT_TRUE(r.Changed());
@@ -104,14 +105,15 @@ TEST_F(JSBuiltinReducerTest, MathMax1) {
Node* effect = graph()->start();
Node* control = graph()->start();
+ Node* context = UndefinedConstant();
Node* frame_state = graph()->start();
TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
TRACED_FOREACH(Type*, t0, kNumberTypes) {
Node* p0 = Parameter(t0, 0);
Node* call = graph()->NewNode(
javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS, language_mode),
- function, UndefinedConstant(), p0, frame_state, frame_state, effect,
- control);
+ function, UndefinedConstant(), p0, context, frame_state, frame_state,
+ effect, control);
Reduction r = Reduce(call);
ASSERT_TRUE(r.Changed());
@@ -126,6 +128,7 @@ TEST_F(JSBuiltinReducerTest, MathMax2) {
Node* effect = graph()->start();
Node* control = graph()->start();
+ Node* context = UndefinedConstant();
Node* frame_state = graph()->start();
TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
TRACED_FOREACH(Type*, t0, kIntegral32Types) {
@@ -135,8 +138,8 @@ TEST_F(JSBuiltinReducerTest, MathMax2) {
Node* call =
graph()->NewNode(javascript()->CallFunction(
4, NO_CALL_FUNCTION_FLAGS, language_mode),
- function, UndefinedConstant(), p0, p1, frame_state,
- frame_state, effect, control);
+ function, UndefinedConstant(), p0, p1, context,
+ frame_state, frame_state, effect, control);
Reduction r = Reduce(call);
ASSERT_TRUE(r.Changed());
@@ -157,6 +160,7 @@ TEST_F(JSBuiltinReducerTest, MathImul) {
Node* effect = graph()->start();
Node* control = graph()->start();
+ Node* context = UndefinedConstant();
Node* frame_state = graph()->start();
TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
TRACED_FOREACH(Type*, t0, kIntegral32Types) {
@@ -166,8 +170,8 @@ TEST_F(JSBuiltinReducerTest, MathImul) {
Node* call =
graph()->NewNode(javascript()->CallFunction(
4, NO_CALL_FUNCTION_FLAGS, language_mode),
- function, UndefinedConstant(), p0, p1, frame_state,
- frame_state, effect, control);
+ function, UndefinedConstant(), p0, p1, context,
+ frame_state, frame_state, effect, control);
Reduction r = Reduce(call);
ASSERT_TRUE(r.Changed());
@@ -187,14 +191,15 @@ TEST_F(JSBuiltinReducerTest, MathFround) {
Node* effect = graph()->start();
Node* control = graph()->start();
+ Node* context = UndefinedConstant();
Node* frame_state = graph()->start();
TRACED_FOREACH(LanguageMode, language_mode, kLanguageModes) {
TRACED_FOREACH(Type*, t0, kNumberTypes) {
Node* p0 = Parameter(t0, 0);
Node* call = graph()->NewNode(
javascript()->CallFunction(3, NO_CALL_FUNCTION_FLAGS, language_mode),
- function, UndefinedConstant(), p0, frame_state, frame_state, effect,
- control);
+ function, UndefinedConstant(), p0, context, frame_state, frame_state,
+ effect, control);
Reduction r = Reduce(call);
ASSERT_TRUE(r.Changed());
« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | test/unittests/compiler/js-context-relaxation-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698