Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1425843003: Add missing include for sleep(). (Closed)

Created:
5 years, 1 month ago by scroggo
Modified:
5 years, 1 month ago
Reviewers:
mtklein, danalbert
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add missing include for sleep(). This used to be leaked unconditionally by libc++. Change-Id: I984ab7328ff3a2499c3c89a6862feaa62b6166de Author: Dan Albert<danalbert@google.com>; Cherry-pick of https://android-review.googlesource.com/#/c/178189/1 This fixes the AOSP mips build. Committed: https://skia.googlesource.com/skia/+/27a58348b2a38bf8cca16dfd8f332d8cd5773270

Patch Set 1 #

Patch Set 2 : Not on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M dm/DM.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
scroggo
5 years, 1 month ago (2015-10-28 15:25:40 UTC) #2
mtklein
lgtm
5 years, 1 month ago (2015-10-28 15:34:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425843003/1
5 years, 1 month ago (2015-10-28 15:34:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/3987)
5 years, 1 month ago (2015-10-28 15:36:39 UTC) #7
mtklein
Oh, duh, Windows doesn't have unistd.h Let's move this after SkTypes.h and guard with !defined(SK_BUILD_FOR_WIN32).
5 years, 1 month ago (2015-10-28 15:38:54 UTC) #8
scroggo
On 2015/10/28 15:38:54, mtklein wrote: > Oh, duh, Windows doesn't have unistd.h Let's move this ...
5 years, 1 month ago (2015-10-28 15:44:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425843003/20001
5 years, 1 month ago (2015-10-28 15:46:06 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 15:56:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/27a58348b2a38bf8cca16dfd8f332d8cd5773270

Powered by Google App Engine
This is Rietveld 408576698