Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1425823005: Update the comment of --quic_version. (Closed)

Created:
5 years, 1 month ago by rjshade
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106955386
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the comment of --quic_version. Merge internal change: 106978852 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (0 generated)
rjshade
5 years, 1 month ago (2015-11-10 20:54:52 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_bin.cc#newcode22 net/tools/quic/quic_client_bin.cc:22: // quic_client http://www.google.com --quic_version=23 --host=${IP} Can you updated quic_simple_client_bin.cc ...
5 years, 1 month ago (2015-11-10 21:33:13 UTC) #2
rjshade
On 2015/11/10 21:33:13, Ryan Hamilton wrote: > https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_bin.cc > File net/tools/quic/quic_client_bin.cc (right): > > https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_bin.cc#newcode22 ...
5 years, 1 month ago (2015-11-11 20:27:30 UTC) #3
Ryan Hamilton
5 years, 1 month ago (2015-11-11 22:14:14 UTC) #4
On 2015/11/11 20:27:30, rjshade wrote:
> On 2015/11/10 21:33:13, Ryan Hamilton wrote:
> >
>
https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_...
> > File net/tools/quic/quic_client_bin.cc (right):
> > 
> >
>
https://codereview.chromium.org/1425823005/diff/1/net/tools/quic/quic_client_...
> > net/tools/quic/quic_client_bin.cc:22: //   quic_client http://www.google.com
> > --quic_version=23  --host=${IP}
> > Can you updated quic_simple_client_bin.cc too?
> > 
> > Feel free to do in the Final CL if that is easier.
> 
> Done in Final CL.

lgtm (though I don't yet see the final CL)

Powered by Google App Engine
This is Rietveld 408576698