Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1425823004: Make dart2js accept constant null values in string interpolations. (Closed)

Created:
5 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make dart2js accept constant null values in string interpolations. Fixes issue #24839. BUG= http://dartbug.com/24839 R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/3c41869d3ccd61f032610d2fd3d19240641cb87c

Patch Set 1 #

Patch Set 2 : Also add test. #

Patch Set 3 : And revert edit of bad file. #

Patch Set 4 : Also test int/bool.fromEnvironment returning null. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/constant_string_interpolation2_test.dart View 1 2 3 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-11-06 08:53:24 UTC) #2
sigurdm
LGTM
5 years, 1 month ago (2015-11-06 08:54:59 UTC) #3
sigurdm
Test LGTM
5 years, 1 month ago (2015-11-06 09:41:49 UTC) #4
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-11-06 09:58:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
3c41869d3ccd61f032610d2fd3d19240641cb87c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698