content/common/frame_messages.h - Issue 1425823002: (DEPRECATED) Send navigation_start to browser process in DidStartProvisionalLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1425823002: (DEPRECATED) Send navigation_start to browser process in DidStartProvisionalLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Name change + blink layering Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_request.h ('K') | « content/browser/loader/navigation_url_loader_unittest.cc ('k') | content/common/navigation_params.h » ('j') | content/common/navigation_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 0e0287497e6b1a3dd437e58dd355fda0ea43c865..bc3ec9217959df624cb3d47fd5f12d43f7f88d50 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -283,6 +283,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::BeginNavigationParams)

IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)

IPC_STRUCT_TRAITS_MEMBER(skip_service_worker)

IPC_STRUCT_TRAITS_MEMBER(request_context_type)

+ IPC_STRUCT_TRAITS_MEMBER(renderer_navigation_start)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::StartNavigationParams)

@@ -731,8 +732,9 @@ IPC_MESSAGE_ROUTED2(FrameHostMsg_RenderProcessGone,

IPC_MESSAGE_ROUTED0(FrameHostMsg_FrameFocused)

// Sent when the renderer starts a provisional load for a frame.

-IPC_MESSAGE_ROUTED1(FrameHostMsg_DidStartProvisionalLoadForFrame,

- GURL /* url */)

+IPC_MESSAGE_ROUTED2(FrameHostMsg_DidStartProvisionalLoadForFrame,

+ GURL /* url */,

+ double /* navigation_start */)

clamy 2015/10/28 12:40:01 We should send a base::TimeTicks or a base::Time.

Charlie Harrison 2015/10/28 14:45:00 Agree. I did it this way due to how we get the inf

// Sent when the renderer fails a provisional load with an error.

IPC_MESSAGE_ROUTED1(FrameHostMsg_DidFailProvisionalLoadWithError,