Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1425823002: (DEPRECATED) Send navigation_start to browser process in DidStartProvisionalLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Name change + blink layering Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 6f46707108e531ceac132639638d387611e5710f..35d53a2184a52ad9636d9e303fb748ebed39354d 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -59,12 +59,14 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
public:
static scoped_ptr<NavigationHandleImpl> Create(
const GURL& url,
- FrameTreeNode* frame_tree_node);
+ FrameTreeNode* frame_tree_node,
+ double navigation_start);
~NavigationHandleImpl() override;
// NavigationHandle implementation:
const GURL& GetURL() override;
bool IsInMainFrame() override;
+ double GetNavigationStart() override;
bool IsPost() override;
const Referrer& GetReferrer() override;
bool HasUserGesture() override;
@@ -161,8 +163,13 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
DID_COMMIT_ERROR_PAGE,
};
+ // |navigation_start| comes from the DidStartProvisionalLoad IPC, which tracks
+ // both renderer-initiated and browser-initiated navigation start.
+ // PlzNavigate: Renderer-initated navigations send this with a BeginNavigation
+ // IPC. Browser-initiated navigations set it at the call-site.
NavigationHandleImpl(const GURL& url,
- FrameTreeNode* frame_tree_node);
+ FrameTreeNode* frame_tree_node,
+ double navigation_start);
NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();
@@ -197,6 +204,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
// The index of the next throttle to check.
size_t next_index_;
+ // The time this navigation started.
+ double navigation_start_;
clamy 2015/10/28 12:40:01 This should be a base::TimeTicks or a base::Time (
+
// This callback will be run when all throttle checks have been performed.
ThrottleChecksFinishedCallback complete_callback_;

Powered by Google App Engine
This is Rietveld 408576698