content/browser/frame_host/navigator.h - Issue 1425823002: (DEPRECATED) Send navigation_start to browser process in DidStartProvisionalLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator.h

Issue 1425823002: (DEPRECATED) Send navigation_start to browser process in DidStartProvisionalLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stop calling didCreateDataSource for same-page navs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator.h

diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h

index e2f737d586ff0a21738c60ff6a2f7213b9e86166..2593aaaaa04f6e3e81997fb172a698b52c6f201d 100644

--- a/content/browser/frame_host/navigator.h

+++ b/content/browser/frame_host/navigator.h

@@ -53,8 +53,10 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {

// Notifications coming from the RenderFrameHosts ----------------------------

// The RenderFrameHostImpl started a provisional load.

- virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host,

- const GURL& url) {};

+ virtual void DidStartProvisionalLoad(

+ RenderFrameHostImpl* render_frame_host,

+ const GURL& url,

+ const base::TimeTicks& navigation_start){};

// The RenderFrameHostImpl has failed a provisional load.

virtual void DidFailProvisionalLoadWithError(