chrome/browser/push_messaging/push_messaging_service_impl.cc - Issue 1425783002: Componentizing GcmProfileService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 1425783002: Componentizing GcmProfileService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix UT errors as per comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_service_impl.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc

index e0c02f21fe6b719e623b31119a3a160faf6a310f..124f883345027592a62f2e96d10ecf22d8e526fd 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc

@@ -21,7 +21,6 @@

#include "chrome/browser/push_messaging/push_messaging_app_identifier.h"

#include "chrome/browser/push_messaging/push_messaging_constants.h"

#include "chrome/browser/push_messaging/push_messaging_service_factory.h"

-#include "chrome/browser/services/gcm/gcm_profile_service.h"

#include "chrome/browser/services/gcm/gcm_profile_service_factory.h"

#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/common/chrome_switches.h"

@@ -29,6 +28,7 @@

#include "chrome/grit/generated_resources.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "components/gcm_driver/gcm_driver.h"

+#include "components/gcm_driver/gcm_profile_service.h"

#include "components/pref_registry/pref_registry_syncable.h"

#include "components/rappor/rappor_utils.h"

#include "content/public/browser/browser_context.h"