components/gcm_driver/gcm_driver_constants.h - Issue 1425783002: Componentizing GcmProfileService.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/gcm_driver/gcm_driver_constants.h

Issue 1425783002: Componentizing GcmProfileService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added DCHECK instead of CHECK Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // A handful of resource-like constants related to the GCM Driver
	sky 2015/10/30 15:36:51 nit: end sentences with '.'. Also, no where could nit: end sentences with '.'. Also, no where could I find what GCM stands for, please document it. Jitu( very slow this week) 2015/11/02 06:50:55 Done. Show quoted text On 2015/10/30 15:36:51, sky wrote: > nit: end sentences with '.'. > > Also, no where could I find what GCM stands for, please document it. Done.
	6

	7 #ifndef COMPONENTS_GCM_DRIVER_GCM_DRIVER_CONSTANTS_H_

	8

	9 #include "base/files/file_path.h"

	10

	11 namespace gcm_driver {

	12

	13 extern const base::FilePath::CharType kGCMStoreDirname[];
	sky 2015/10/30 15:36:51 Please add comments. Please add comments. Jitu( very slow this week) 2015/11/02 06:50:55 Done. Show quoted text On 2015/10/30 15:36:51, sky wrote: > Please add comments. Done.
	14

	15 } // namespace gcm_driver

	16

	17 #endif // COMPONENTS_GCM_DRIVER_GCM_DRIVER_CONSTANTS_H_

OLD	NEW