Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1425773002: [turbofan] Lower abstract equality of boolean values. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower abstract equality of boolean values. Abstract equality of boolean values reduces to reference equality. R=verwaest@chromium.org Committed: https://crrev.com/89ffdbc26ac8f222dfa8d15dc21ede19a946569d Cr-Commit-Position: refs/heads/master@{#31591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-27 07:38:29 UTC) #1
Benedikt Meurer
Hey Toon, Easy one for TurboFan starters. :-) Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-10-27 07:39:15 UTC) #2
Toon Verwaest
lgtm. no tests added though?
5 years, 1 month ago (2015-10-27 07:42:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425773002/1
5 years, 1 month ago (2015-10-27 08:10:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 08:11:53 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 08:12:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89ffdbc26ac8f222dfa8d15dc21ede19a946569d
Cr-Commit-Position: refs/heads/master@{#31591}

Powered by Google App Engine
This is Rietveld 408576698