Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1425723004: Properly handle parsing a '%'-prefixed runtime call as a binding pattern (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly handle parsing a '%'-prefixed runtime call as a binding pattern R=rossberg@chromium.org BUG=chromium:552302 LOG=n Committed: https://crrev.com/9a8c0119efb243cfd1400dcd160cda20ac5157c3 Cr-Commit-Position: refs/heads/master@{#31890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/preparser.h View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-552302.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 1 month ago (2015-11-06 18:33:13 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-11-09 13:26:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425723004/1
5 years, 1 month ago (2015-11-09 15:15:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 15:32:07 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 15:32:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a8c0119efb243cfd1400dcd160cda20ac5157c3
Cr-Commit-Position: refs/heads/master@{#31890}

Powered by Google App Engine
This is Rietveld 408576698