Issue 14257006: MIPS: Fix NaN handling for start index in ArraySplice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14257006: MIPS: Fix NaN handling for start index in ArraySplice. (Closed)

Created:
7 years, 8 months ago by dusmil

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger, Paul Lind, Toon Verwaest, kisg, palfia, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix NaN handling for start index in ArraySplice. Casting NaN to int is unpredictable, on different architectures it produces different int value. TEST=test262/S15.4.4.10_A2.1_T2, S15.4.4.10_A2.2_T2, S15.4.4.12_A2.1_T2 BUG= Committed: http://code.google.com/p/v8/source/detail?r=14426

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/builtins.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

lgtm, Michael or Toon, could you PTAL? This is outside the mips arch code.

7 years, 8 months ago (2013-04-23 15:13:09 UTC) #2

Committed manually as r14426 (presubmit successful).

Expand Messages | Collapse Messages