Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1425693004: mandoline: Fix mandoline release build on Linux. (Closed)

Created:
5 years, 1 month ago by Elliot Glaysher
Modified:
5 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Fix mandoline release build on Linux. BUG=548694 TBR=ben@chromium.org Committed: https://crrev.com/113c0a979a892ce1817ae885509c0c76d11c2fab Cr-Commit-Position: refs/heads/master@{#357141}

Patch Set 1 #

Patch Set 2 : Stylistically, platform defines go at the end. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mojo/runner/child/native_apptest_target.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Elliot Glaysher
tbring this simple compile fix.
5 years, 1 month ago (2015-10-30 18:05:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425693004/20001
5 years, 1 month ago (2015-10-30 18:06:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 18:37:44 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/113c0a979a892ce1817ae885509c0c76d11c2fab Cr-Commit-Position: refs/heads/master@{#357141}
5 years, 1 month ago (2015-10-30 18:38:21 UTC) #10
Ben Goodger (Google)
5 years, 1 month ago (2015-10-30 19:50:47 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698