Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1425663002: [Android] When generating static libs, generate "fat" static libs

Created:
5 years, 1 month ago by chris.a.williams
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M icu.gyp View 3 chunks +11 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (3 generated)
Michael Achenbach
5 years, 1 month ago (2015-10-26 19:48:27 UTC) #4
I'm not an owner of this. Has the change been tested?

https://codereview.chromium.org/1425663002/diff/1/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/1425663002/diff/1/icu.gyp#newcode181
icu.gyp:181: [ 'componen!="shared_library"', {
s/componen/component ?

Powered by Google App Engine
This is Rietveld 408576698