Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1425643004: Revert of merge to m47 fix for not calling eviction when atlas evicts (Closed)

Created:
5 years, 1 month ago by joshualitt
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m47
Target Ref:
refs/heads/chrome/m47
Project:
skia
Visibility:
Public.

Description

Revert of merge to m47 fix for not calling eviction when atlas evicts (patchset #1 id:1 of https://codereview.chromium.org/1408763006/ ) Reason for revert: reverting in case this is breaking the bots Original issue's description: > merge to m47 fix for not calling eviction when atlas evicts > > BUG=551904 > NOTREECHECKS=true > NOTRY=true > NOPRESUBMIT=true > > Committed: https://skia.googlesource.com/skia/+/dac527240dae4d0bce268639a13d89905164356a TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=551904 Committed: https://skia.googlesource.com/skia/+/b6589d8d5a088f5467e20a7d7cf3bb1976d2b176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/gpu/GrResourceProvider.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
joshualitt
Created Revert of merge to m47 fix for not calling eviction when atlas evicts
5 years, 1 month ago (2015-11-09 22:28:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425643004/1
5 years, 1 month ago (2015-11-09 22:28:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b6589d8d5a088f5467e20a7d7cf3bb1976d2b176
5 years, 1 month ago (2015-11-09 22:28:31 UTC) #3
bsalomon
5 years, 1 month ago (2015-11-09 23:54:02 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1418603004/ by bsalomon@google.com.

The reason for reverting is: tests are broken after revert so reverting the
revert.

Powered by Google App Engine
This is Rietveld 408576698