Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 1425643003: Oilpan: Don't send a BlinkGC.CompleteSweep UMA from non-main threads (Closed)

Created:
5 years, 1 month ago by haraken
Modified:
5 years, 1 month ago
Reviewers:
Yuta Kitamura
CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Don't send a BlinkGC.CompleteSweep UMA from non-main threads We send other UMAs about sweeping only from the main thread. BlinkGC.CompleteSweep should follow the rule. BUG=548628 Committed: https://crrev.com/620e55b3dd63c81bb8c405c9c1cfc96f01554aec Cr-Commit-Position: refs/heads/master@{#357057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL In general, it is not a good idea to change a condition where we ...
5 years, 1 month ago (2015-10-29 14:09:21 UTC) #3
Yuta Kitamura
lgtm
5 years, 1 month ago (2015-10-30 04:57:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425643003/1
5 years, 1 month ago (2015-10-30 05:33:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 08:23:21 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:24:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/620e55b3dd63c81bb8c405c9c1cfc96f01554aec
Cr-Commit-Position: refs/heads/master@{#357057}

Powered by Google App Engine
This is Rietveld 408576698