[Interpreter] Add support for loading from / storing to outer context variables.

src/compiler/raw-machine-assembler.h

Index: src/compiler/raw-machine-assembler.h
diff --git a/src/compiler/raw-machine-assembler.h b/src/compiler/raw-machine-assembler.h
index c3db3be963dcc704add4acf03b213c2e428e9eb4..17e3bc211652181a3f1b444ecbf22cb9a19636e6 100644
--- a/src/compiler/raw-machine-assembler.h
+++ b/src/compiler/raw-machine-assembler.h
@@ -126,12 +126,15 @@ class RawMachineAssembler {
     return AddNode(machine()->Load(rep), base, index, graph()->start(),
                    graph()->start());
   }
-  Node* Store(MachineType rep, Node* base, Node* value) {
-    return Store(rep, base, IntPtrConstant(0), value);
-  }
-  Node* Store(MachineType rep, Node* base, Node* index, Node* value) {
-    return AddNode(machine()->Store(StoreRepresentation(rep, kNoWriteBarrier)),
-                   base, index, value, graph()->start(), graph()->start());
+  Node* Store(MachineType rep, Node* base, Node* value,
+              WriteBarrierKind write_barrier_kind = kNoWriteBarrier) {

[Michael Starzinger, 2015/10/26 13:28:13]

Joking aside: How much overhead would it be to not have a default argument here?
If it turns out to be, lets say, less than ten changes in the test suite, I
would vote for going for it. WDYT?

[rmcilroy, 2015/10/26 15:37:51]

Good point - done by changing Store to take a StoreRepresentation instead of
separate MachineType/WriteBarrierKind arguments (although it was more like 130
change... ;)).

+    return Store(rep, base, IntPtrConstant(0), value, write_barrier_kind);
+  }
+  Node* Store(MachineType rep, Node* base, Node* index, Node* value,
+              WriteBarrierKind write_barrier_kind = kNoWriteBarrier) {

[Michael Starzinger, 2015/10/26 13:28:13]

Likewise.

[rmcilroy, 2015/10/26 15:37:51]

Done.

+    return AddNode(
+        machine()->Store(StoreRepresentation(rep, write_barrier_kind)), base,
+        index, value, graph()->start(), graph()->start());
   }
 
   // Arithmetic Operations.