Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/compiler/mips/code-generator-mips.cc

Issue 1425603002: MIPS64: Fix r6 boolean materializations after a float32 compare. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips32 change, for consistency (no bug on mips32r6) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 #include "src/compiler/code-generator-impl.h" 6 #include "src/compiler/code-generator-impl.h"
7 #include "src/compiler/gap-resolver.h" 7 #include "src/compiler/gap-resolver.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/osr.h" 9 #include "src/compiler/osr.h"
10 #include "src/mips/macro-assembler-mips.h" 10 #include "src/mips/macro-assembler-mips.h"
(...skipping 1083 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 } else { 1094 } else {
1095 __ Movt(result, zero_reg); 1095 __ Movt(result, zero_reg);
1096 } 1096 }
1097 } else { 1097 } else {
1098 if (instr->arch_opcode() == kMipsCmpD) { 1098 if (instr->arch_opcode() == kMipsCmpD) {
1099 __ cmp(cc, L, kDoubleCompareReg, left, right); 1099 __ cmp(cc, L, kDoubleCompareReg, left, right);
1100 } else { 1100 } else {
1101 DCHECK(instr->arch_opcode() == kMipsCmpS); 1101 DCHECK(instr->arch_opcode() == kMipsCmpS);
1102 __ cmp(cc, W, kDoubleCompareReg, left, right); 1102 __ cmp(cc, W, kDoubleCompareReg, left, right);
1103 } 1103 }
1104 __ mfc1(at, kDoubleCompareReg); 1104 __ mfc1(result, kDoubleCompareReg);
1105 __ srl(result, at, 31); // Cmp returns all 1s for true. 1105 __ andi(result, result, 1); // Cmp returns all 1's/0's, use only LSB.
1106 if (!predicate) // Toggle result for not equal. 1106 if (!predicate) // Toggle result for not equal.
1107 __ xori(result, result, 1); 1107 __ xori(result, result, 1);
1108 } 1108 }
1109 return; 1109 return;
1110 } else { 1110 } else {
1111 PrintF("AssembleArchBranch Unimplemented arch_opcode is : %d\n", 1111 PrintF("AssembleArchBranch Unimplemented arch_opcode is : %d\n",
1112 instr->arch_opcode()); 1112 instr->arch_opcode());
1113 TRACE_UNIMPL(); 1113 TRACE_UNIMPL();
1114 UNIMPLEMENTED(); 1114 UNIMPLEMENTED();
1115 } 1115 }
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
1460 padding_size -= v8::internal::Assembler::kInstrSize; 1460 padding_size -= v8::internal::Assembler::kInstrSize;
1461 } 1461 }
1462 } 1462 }
1463 } 1463 }
1464 1464
1465 #undef __ 1465 #undef __
1466 1466
1467 } // namespace compiler 1467 } // namespace compiler
1468 } // namespace internal 1468 } // namespace internal
1469 } // namespace v8 1469 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/mips64/code-generator-mips64.cc » ('j') | src/compiler/mips64/code-generator-mips64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698