third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp - Issue 1425593007: Separate display item clients for negative and normal/positive z-order children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp

Issue 1425593007: Separate display item clients for negative and normal/positive z-order children (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Struct DisplayItemClient Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp b/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp

index 724cbf11de29b5865bdd3a616737f8ef319ee674..dc27bbf659960106e036deee999436b452f3692e 100644

--- a/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp

+++ b/third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp

@@ -30,6 +30,7 @@ TEST_F(TableCellPainterTest, TableCellBackgroundInterestRect)

PaintLayer& rootLayer = *layoutView.layer();

LayoutObject& cell1 = *document().getElementById("cell1")->layoutObject();

LayoutObject& cell2 = *document().getElementById("cell2")->layoutObject();

+ DisplayItemClientWrapper rootLayerClient(rootLayer.displayItemClientForNormalAndPositiveZOrderChildren());

rootPaintController().invalidateAll();

updateLifecyclePhasesBeforePaint();

@@ -39,9 +40,9 @@ TEST_F(TableCellPainterTest, TableCellBackgroundInterestRect)

EXPECT_DISPLAY_LIST(rootPaintController().displayItemList(), 4,

TestDisplayItem(layoutView, DisplayItem::BoxDecorationBackground),

- TestDisplayItem(rootLayer, subsequenceType),

+ TestDisplayItem(rootLayerClient, DisplayItem::Subsequence),

TestDisplayItem(cell1, DisplayItem::TableCellBackgroundFromRow),

- TestDisplayItem(rootLayer, endSubsequenceType));

+ TestDisplayItem(rootLayerClient, DisplayItem::EndSubsequence));

updateLifecyclePhasesBeforePaint();

interestRect = IntRect(0, 300, 200, 1000);

@@ -50,9 +51,9 @@ TEST_F(TableCellPainterTest, TableCellBackgroundInterestRect)