Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 1425593007: Separate display item clients for negative and normal/positive z-order children (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index 51bbe108a1fafcc4745b9155e5492f866d6e8475..cbaa5e1145bb452ebd7dd694037f4da5102959bc 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -66,7 +66,7 @@ void PaintController::processNewItem(DisplayItem& displayItem)
// Verify noop begin/end pairs have been removed.
if (m_newDisplayItemList.size() >= 2 && displayItem.isEnd()) {
const auto& beginDisplayItem = m_newDisplayItemList[m_newDisplayItemList.size() - 2];
- if (beginDisplayItem.isBegin() && !beginDisplayItem.isSubsequence() && !beginDisplayItem.drawsContent())
+ if (beginDisplayItem.isBegin() && beginDisplayItem.type() != DisplayItem::Subsequence && !beginDisplayItem.drawsContent())
ASSERT(!displayItem.isEndAndPairedWith(beginDisplayItem.type()));
}
#endif
@@ -246,9 +246,9 @@ DisplayItemList::iterator PaintController::findOutOfOrderCachedItemForward(const
void PaintController::copyCachedSubsequence(DisplayItemList::iterator& currentIt, DisplayItemList& updatedList)
{
- ASSERT(currentIt->isSubsequence());
+ ASSERT(currentIt->type() == DisplayItem::Subsequence);
ASSERT(!currentIt->scope());
- DisplayItem::Id endSubsequenceId(currentIt->client(), DisplayItem::subsequenceTypeToEndSubsequenceType(currentIt->type()), 0);
+ DisplayItem::Id endSubsequenceId(currentIt->client(), DisplayItem::EndSubsequence, 0);
do {
// We should always find the EndSubsequence display item.
ASSERT(currentIt != m_currentPaintArtifact.displayItemList().end());
@@ -362,9 +362,9 @@ void PaintController::commitNewDisplayItems()
updatedList.appendByMoving(*currentIt);
++currentIt;
} else {
- ASSERT(newDisplayItem.isCachedSubsequence());
+ ASSERT(newDisplayItem.type() == DisplayItem::CachedSubsequence);
copyCachedSubsequence(currentIt, updatedList);
- ASSERT(updatedList.last().isEndSubsequence());
+ ASSERT(updatedList.last().type() == DisplayItem::EndSubsequence);
}
} else {
ASSERT(!newDisplayItem.isDrawing()
@@ -458,7 +458,7 @@ void PaintController::checkUnderInvalidation(DisplayItemList::iterator& newIt, D
return;
}
- ASSERT(newIt->isSubsequence());
+ ASSERT(newIt->type() == DisplayItem::Subsequence);
#ifndef NDEBUG
CString messagePrefix = String::format("(In CachedSubsequence of %s)", newIt->clientDebugString().utf8().data()).utf8();
@@ -466,7 +466,7 @@ void PaintController::checkUnderInvalidation(DisplayItemList::iterator& newIt, D
CString messagePrefix = "(In CachedSubsequence)";
#endif
- DisplayItem::Id endSubsequenceId(newIt->client(), DisplayItem::subsequenceTypeToEndSubsequenceType(newIt->type()), 0);
+ DisplayItem::Id endSubsequenceId(newIt->client(), DisplayItem::EndSubsequence, 0);
while (true) {
ASSERT(newIt != m_newDisplayItemList.end());
if (newIt->isCached())

Powered by Google App Engine
This is Rietveld 408576698