chrome/service/service_ipc_server.cc - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_ipc_server.cc

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: fixed compile problems on non-Windows builds Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/service_ipc_server.cc

diff --git a/chrome/service/service_ipc_server.cc b/chrome/service/service_ipc_server.cc

index 869c4fbcd3de1e59aad2eacb04945590cb48c85e..4d6e565195ced818c869c658fd1a8352708620f1 100644

--- a/chrome/service/service_ipc_server.cc

+++ b/chrome/service/service_ipc_server.cc

@@ -123,7 +123,10 @@ void ServiceIPCServer::OnGetHistograms() {

new base::HistogramDeltaSerialization("ServiceProcess"));

}

std::vector<std::string> deltas;

- histogram_delta_serializer_->PrepareAndSerializeDeltas(&deltas);

+ // "false" to SPerpareAndSerializeDeltas() indicates to *not* include

Alexei Svitkine (slow) 2016/01/22 16:15:16 Nit: SPerpareAndSerializeDeltas() -> PerpareAndSer

bcwhite 2016/01/22 17:17:48 Done.

+ // histograms held in persistent storage on the assumption that they will be

+ // visible to the recipient through other means.

+ histogram_delta_serializer_->PrepareAndSerializeDeltas(&deltas, false);

channel_->Send(new ServiceHostMsg_Histograms(deltas));

}

« chrome/browser/chrome_browser_field_trials.cc ('K') | « chrome/browser/chrome_browser_field_trials.cc ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »