components/metrics/metrics_service_accessor.cc - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service_accessor.cc

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: fixed compile problems on non-Windows builds Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_service_accessor.cc

diff --git a/components/metrics/metrics_service_accessor.cc b/components/metrics/metrics_service_accessor.cc

index ce301c9bb14523c4f8da990636ad5f0af6daa6f6..f8099f4e720842e69caa8cfb0b699cdfa0ba368b 100644

--- a/components/metrics/metrics_service_accessor.cc

+++ b/components/metrics/metrics_service_accessor.cc

@@ -16,7 +16,8 @@ namespace metrics {

// static

bool MetricsServiceAccessor::IsMetricsReportingEnabled(

PrefService* pref_service) {

- return IsMetricsReportingEnabledWithPrefValue(

+ // Testing Metrics -- DO NOT COMMIT

Alexei Svitkine (slow) 2016/01/18 19:25:36 Remove. This is also responsible for a few red bot

bcwhite 2016/01/22 15:24:53 Done.

+ return true || IsMetricsReportingEnabledWithPrefValue(

pref_service->GetBoolean(prefs::kMetricsReportingEnabled));

}

« components/metrics/metrics_service.cc ('K') | « components/metrics/metrics_service.cc ('k') | content/child/child_histogram_message_filter.cc » ('j') | no next file with comments »