base/metrics/sample_vector.h - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/sample_vector.h

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: extract common histogram FactoryGet code; extract histogram persistence into seperate files Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/sample_vector.h

diff --git a/base/metrics/sample_vector.h b/base/metrics/sample_vector.h

index 51803b05288ef075982e299462545982cea7c972..99cb61e5a008f2016266c2a20781f5c36d5169c3 100644

--- a/base/metrics/sample_vector.h

+++ b/base/metrics/sample_vector.h

@@ -51,6 +51,7 @@ class BASE_EXPORT SampleVector : public HistogramSamples {

private:

FRIEND_TEST_ALL_PREFIXES(HistogramTest, CorruptSampleCounts);

+ FRIEND_TEST_ALL_PREFIXES(SharedHistogramTest, CorruptSampleCounts);

// In the case where this class manages the memory, here it is.

std::vector<HistogramBase::AtomicCount> local_counts_;

« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/statistics_recorder.h » ('j') | chrome/browser/chrome_browser_field_trials.cc » ('J')