base/metrics/histogram_snapshot_manager_unittest.cc - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_snapshot_manager_unittest.cc

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: extract common histogram FactoryGet code; extract histogram persistence into seperate files Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_snapshot_manager_unittest.cc

diff --git a/base/metrics/histogram_snapshot_manager_unittest.cc b/base/metrics/histogram_snapshot_manager_unittest.cc

index e9e7398bca9fa9761263c8878b780430c3c1f233..20b324eb18fc107d0ce8a696064da5fb75d1ce5a 100644

--- a/base/metrics/histogram_snapshot_manager_unittest.cc

+++ b/base/metrics/histogram_snapshot_manager_unittest.cc

@@ -63,8 +63,9 @@ TEST_F(HistogramSnapshotManagerTest, PrepareDeltasNoFlagsFilter) {

UMA_HISTOGRAM_ENUMERATION("UmaHistogram", 1, 2);

UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);

- histogram_snapshot_manager_.PrepareDeltas(HistogramBase::kNoFlags,

- HistogramBase::kNoFlags);

+ histogram_snapshot_manager_.PrepareDeltas(

+ StatisticsRecorder::begin(false), StatisticsRecorder::end(),

+ HistogramBase::kNoFlags, HistogramBase::kNoFlags);

const std::vector<std::string>& histograms =

histogram_flattener_delta_recorder_.GetRecordedDeltaHistogramNames();

@@ -79,6 +80,7 @@ TEST_F(HistogramSnapshotManagerTest, PrepareDeltasUmaHistogramFlagFilter) {

UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);

histogram_snapshot_manager_.PrepareDeltas(

+ StatisticsRecorder::begin(false), StatisticsRecorder::end(),

HistogramBase::kNoFlags, HistogramBase::kUmaTargetedHistogramFlag);

const std::vector<std::string>& histograms =

@@ -94,6 +96,7 @@ TEST_F(HistogramSnapshotManagerTest,

UMA_STABILITY_HISTOGRAM_ENUMERATION("UmaStabilityHistogram", 1, 2);

histogram_snapshot_manager_.PrepareDeltas(

+ StatisticsRecorder::begin(false), StatisticsRecorder::end(),

HistogramBase::kNoFlags, HistogramBase::kUmaStabilityHistogramFlag);

const std::vector<std::string>& histograms =

« no previous file with comments | « base/metrics/histogram_snapshot_manager.cc ('k') | base/metrics/histogram_unittest.cc » ('j') | chrome/browser/chrome_browser_field_trials.cc » ('J')