base/metrics/histogram_delta_serialization_unittest.cc - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_delta_serialization_unittest.cc

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: extract common histogram FactoryGet code; extract histogram persistence into seperate files Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/histogram_delta_serialization.cc ('k') | base/metrics/histogram_persistence.h » ('j') | chrome/browser/chrome_browser_field_trials.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/histogram_delta_serialization_unittest.cc

diff --git a/base/metrics/histogram_delta_serialization_unittest.cc b/base/metrics/histogram_delta_serialization_unittest.cc

index b53520c5098787539d7d14691597cf125fde7be3..93f719826f3e7f207077ef65d1fbc7e84476aae5 100644

--- a/base/metrics/histogram_delta_serialization_unittest.cc

+++ b/base/metrics/histogram_delta_serialization_unittest.cc

@@ -18,7 +18,7 @@ TEST(HistogramDeltaSerializationTest, DeserializeHistogramAndAddSamples) {

HistogramDeltaSerialization serializer("HistogramDeltaSerializationTest");

std::vector<std::string> deltas;

// Nothing was changed yet.

- serializer.PrepareAndSerializeDeltas(&deltas);

+ serializer.PrepareAndSerializeDeltas(&deltas, true);

EXPECT_TRUE(deltas.empty());

HistogramBase* histogram = Histogram::FactoryGet(

@@ -28,7 +28,7 @@ TEST(HistogramDeltaSerializationTest, DeserializeHistogramAndAddSamples) {

histogram->Add(100);

histogram->Add(1000);

- serializer.PrepareAndSerializeDeltas(&deltas);

+ serializer.PrepareAndSerializeDeltas(&deltas, true);

EXPECT_FALSE(deltas.empty());

HistogramDeltaSerialization::DeserializeAndAddSamples(deltas);

« no previous file with comments | « base/metrics/histogram_delta_serialization.cc ('k') | base/metrics/histogram_persistence.h » ('j') | chrome/browser/chrome_browser_field_trials.cc » ('J')