base/metrics/histogram_samples.h - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_samples.h

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: added a couple tests (and fixed related issues) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_samples.h

diff --git a/base/metrics/histogram_samples.h b/base/metrics/histogram_samples.h

index bbd0e6d24e2e58f05d300f5c0661825f34605b77..76f84ff571f27d2a8f10852e0d11e1f1027c348e 100644

--- a/base/metrics/histogram_samples.h

+++ b/base/metrics/histogram_samples.h

@@ -31,11 +31,8 @@ class BASE_EXPORT HistogramSamples {

// accuracy of this value; there may be races during histogram

// accumulation and snapshotting that we choose to accept. It should

// be treated as approximate.

-#ifdef ARCH_CPU_64_BITS

- subtle::Atomic64 sum;

-#else // No Atomic64 on 32-bit platforms.

+ // TODO(bcwhite): Change this to std::atomic<uint64>.

int64 sum;

-#endif

// A "redundant" count helps identify memory corruption. It redundantly

// stores the total number of samples accumulated in the histogram. We

« base/metrics/histogram_base.h ('K') | « base/metrics/histogram_delta_serialization_unittest.cc ('k') | base/metrics/histogram_samples.cc » ('j') | no next file with comments »