Issue 142553005: Once again: Fixed some lifetime/ownership issues in cctest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142553005: Once again: Fixed some lifetime/ownership issues in cctest (Closed)

Created:
6 years, 10 months ago by Sven Panne

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Once again: Fixed some lifetime/ownership issues in cctest * Fixed lifetime issue in cctest/test-heap-profiler/HeapSnapshotJSONSerialization. * Fixed ownership issue in cctest/test-api/ContainsOnlyOneByte. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18978

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	test/cctest/test-api.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 10 months ago (2014-01-31 09:59:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18978 (presubmit successful).

Expand Messages | Collapse Messages