Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: mojo/edk/system/BUILD.gn

Issue 1425473003: Get rid of system_export.h, etc. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/BUILD.gn ('k') | mojo/edk/util/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/BUILD.gn
diff --git a/mojo/edk/system/BUILD.gn b/mojo/edk/system/BUILD.gn
index aabeb7574ed216ff68f403d21acf3d5f093147a9..4cb7ad1fb7f8a1fc3c26d79f5f71a21944caba33 100644
--- a/mojo/edk/system/BUILD.gn
+++ b/mojo/edk/system/BUILD.gn
@@ -10,11 +10,8 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
+# TODO(vtl): Should we get rid of this?
jamesr 2015/10/23 23:12:55 yes?
viettrungluu 2015/10/24 00:04:57 Yeah, but then there's a cascade of things that re
config("system_config") {
- defines = [
- # Ensures that dependent projects import the core functions on Windows.
- "MOJO_USE_SYSTEM_IMPL",
- ]
}
component("system") {
@@ -120,8 +117,6 @@ component("system") {
"waiter.h",
]
- defines = [ "MOJO_SYSTEM_IMPLEMENTATION" ]
-
all_dependent_configs = [ ":system_config" ]
public_deps = [
« no previous file with comments | « mojo/edk/embedder/BUILD.gn ('k') | mojo/edk/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698