Issue 1425473003: Get rid of system_export.h, etc.

Issue 1425473003: Get rid of system_export.h, etc. (Closed)

Created:
5 years, 2 months ago by viettrungluu

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Get rid of system_export.h, etc. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/faf1aaa29f65812a5ce6c1002ba2f8fd810b99d4

Patch Set 1 #

Total comments: 2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -203 lines)			Patch
M	mojo/edk/embedder/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/edk/system/BUILD.gn	View	2 chunks	+1 line, -6 lines	2 comments	Download
M	mojo/edk/util/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/public/c/system/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/c/system/buffer.h	View	5 chunks	+8 lines, -9 lines	0 comments	Download
M	mojo/public/c/system/core.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/public/c/system/data_pipe.h	View	8 chunks	+21 lines, -26 lines	0 comments	Download
M	mojo/public/c/system/functions.h	View	5 chunks	+14 lines, -15 lines	0 comments	Download
M	mojo/public/c/system/message_pipe.h	View	4 chunks	+13 lines, -16 lines	0 comments	Download
D	mojo/public/c/system/system_export.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	mojo/public/platform/native/BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/public/platform/native/system_impl_private.h	View	3 chunks	+76 lines, -90 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/1425473003/diff/1/mojo/edk/system/BUILD.gn File mojo/edk/system/BUILD.gn (right): https://codereview.chromium.org/1425473003/diff/1/mojo/edk/system/BUILD.gn#newcode13 mojo/edk/system/BUILD.gn:13: # TODO(vtl): Should we get rid of this? ...

5 years, 2 months ago (2015-10-23 23:12:55 UTC) #2

viettrungluu

Committed patchset #1 (id:1) manually as faf1aaa29f65812a5ce6c1002ba2f8fd810b99d4 (presubmit successful).

5 years, 2 months ago (2015-10-24 00:01:29 UTC) #3

viettrungluu

5 years, 2 months ago (2015-10-24 00:04:57 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1425473003/diff/1/mojo/edk/system/BUILD.gn
File mojo/edk/system/BUILD.gn (right):

https://codereview.chromium.org/1425473003/diff/1/mojo/edk/system/BUILD.gn#ne...
mojo/edk/system/BUILD.gn:13: # TODO(vtl): Should we get rid of this?
On 2015/10/23 23:12:55, jamesr wrote:
> yes?

Yeah, but then there's a cascade of things that refers to it (and then the
question of whether we should get rid of them). (If we think that there'll never
need to be config for stuff in the EDK, then we can get rid of them too. But if
we do need config for the EDK, then it'd be slightly annoying to bring back.)

So I might get rid of it as a separate change, which would at least make it
easier to revert.

Expand Messages | Collapse Messages