Issue 1425463004: Fix ThreadIterator_AddFindRemove test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1425463004: Fix ThreadIterator_AddFindRemove test (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix ThreadIterator_AddFindRemove test - A pointer test was unsafe because the allocator could recycle the address for a new thread. Fixes #24692 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/b83e5a718ec3c07c459cb369b786b514c807ddae

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -38 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/thread.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/thread.cc	View	2 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View	2 chunks	+6 lines, -36 lines	0 comments	Download

Total messages: 5 (2 generated)

Cutch

5 years, 1 month ago (2015-10-26 18:07:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b83e5a718ec3c07c459cb369b786b514c807ddae (presubmit successful).