Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1425443002: [tracing] Remove counter logic and just use address on glyph cache dumps (Closed)

Created:
5 years, 2 months ago by ssid
Modified:
5 years, 2 months ago
Reviewers:
petrcermak, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[tracing] Remove counter logic and just use address on glyph cache dumps This CL removes the logic of counting the index of glyphs and uses the address of the glyph object for dump name. This makes the dump names consistent across multiple dumps. BUG=543479 Committed: https://skia.googlesource.com/skia/+/93775bd279e7db34f074ce9820531663fa708696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M src/core/SkGlyphCache.cpp View 4 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ssid
PTAL, thanks
5 years, 2 months ago (2015-10-23 10:58:15 UTC) #3
petrcermak
Thanks for taking care of this :-) LGTM with one description nit: s/makes the dump ...
5 years, 2 months ago (2015-10-23 11:11:11 UTC) #4
ssid
Small fix, PTAL, thanks
5 years, 2 months ago (2015-10-23 12:57:39 UTC) #8
reed1
lgtm
5 years, 2 months ago (2015-10-23 17:35:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425443002/1
5 years, 2 months ago (2015-10-23 17:38:51 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 17:49:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93775bd279e7db34f074ce9820531663fa708696

Powered by Google App Engine
This is Rietveld 408576698