Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1425433002: [es6] Ship --harmony-completion. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Ship --harmony-completion. R=rossberg BUG= Committed: https://crrev.com/e5ae33b55b2120a11199dbd3c3ae77c5799578bf Cr-Commit-Position: refs/heads/master@{#31521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
neis
5 years, 2 months ago (2015-10-23 10:45:48 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-23 11:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425433002/1
5 years, 2 months ago (2015-10-23 11:09:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10910)
5 years, 2 months ago (2015-10-23 11:43:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425433002/1
5 years, 2 months ago (2015-10-23 12:57:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 13:10:55 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:11:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5ae33b55b2120a11199dbd3c3ae77c5799578bf
Cr-Commit-Position: refs/heads/master@{#31521}

Powered by Google App Engine
This is Rietveld 408576698