Issue 142543007: Revert of r13384 (Stateful PathRenderer implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142543007: Revert of r13384 (Stateful PathRenderer implementation) (Closed)

Created:
6 years, 10 months ago by robertphillips

Modified:
6 years, 10 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Revert of r13384 (Stateful PathRenderer implementation - https://codereview.chromium.org/23926019/). In some circumstances path renderers need to be called reentrantly. For example, when generating a clipPath mask while in the midst of rendering a path. TBR=bsalomon@google.com

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -229 lines)			Patch
M	include/gpu/GrContext.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	include/gpu/GrPathRendererChain.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	12 chunks	+59 lines, -64 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	5 chunks	+6 lines, -12 lines	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.h	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	src/gpu/GrDefaultPathRenderer.cpp	View	9 chunks	+23 lines, -15 lines	0 comments	Download
M	src/gpu/GrPathRenderer.h	View	6 chunks	+35 lines, -76 lines	0 comments	Download
M	src/gpu/GrPathRendererChain.cpp	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/gpu/GrSoftwarePathRenderer.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/gpu/GrSoftwarePathRenderer.cpp	View	5 chunks	+9 lines, -6 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.h	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverPathRenderer.cpp	View	4 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

committed as r13409

Expand Messages | Collapse Messages