[Android] Make gyp/apk_install.py resilient to user actions

[Android] Make gyp/apk_install.py resilient to user actions

If a user reinstalls/uninstalls/etc an APK, then the next build of that
APK should always install it (regardless of whether the md5sum of the
inputs matches the recording or not).

Adds an option to CheckCallAndRecord to force the call.

NOTRY=true
BUG=158821, 234048
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196170

[Yaron, 2013-04-22 22:02:40]

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install.py
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:24: from pylib.utils import apk_helper
This isn't in the gyp deps but I assume you ignored it since it's not often
changed

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:32: # -rw-r--r-- system   system    7376582
2013-04-19 16:34 org.chromium.chrome.testshell-1.apk
I see a bunch of -1 and -2 apks on my local device. How do you reconcile the
two? Can there never be both a -1 version and a -2 version for the same apk? Did
you test this on an ICS device?

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:33: apk_matcher = lambda s:
re.match('.*%s(-[0-9]*)?.apk.*' % apk_package, s)
Maybe end with "$"? You don't want to pick up misc .d files and or stamp files.
They aren't currently on the device but this seems more correct.

[cjhopman, 2013-04-24 00:16:26]

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install.py
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:24: from pylib.utils import apk_helper
On 2013/04/22 22:02:40, Yaron wrote:
> This isn't in the gyp deps but I assume you ignored it since it's not often
> changed

Yeah, it's just infeasible to specify all the imported python modules (in fact,
anything that imports android_commands should technically have apk_helper in
it's gyp inputs because android_commands imports it).

Enforcing that we only import from gyp/util would solve this but would require
duplicating some functionality (we only use a very small bit of these other
scripts though).

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:32: # -rw-r--r-- system   system    7376582
2013-04-19 16:34 org.chromium.chrome.testshell-1.apk
On 2013/04/22 22:02:40, Yaron wrote:
> I see a bunch of -1 and -2 apks on my local device. How do you reconcile the
> two? Can there never be both a -1 version and a -2 version for the same apk?
Did
> you test this on an ICS device? 

My understanding is that there can only be one. On older devices there is no
-1/-2 and this matches that fine.

https://codereview.chromium.org/14254005/diff/1/build/android/gyp/apk_install...
build/android/gyp/apk_install.py:33: apk_matcher = lambda s:
re.match('.*%s(-[0-9]*)?.apk.*' % apk_package, s)
On 2013/04/22 22:02:40, Yaron wrote:
> Maybe end with "$"? You don't want to pick up misc .d files and or stamp
files.
> They aren't currently on the device but this seems more correct.

Done.

[Yaron, 2013-04-24 00:52:05]

lgtm

[commit-bot: I haz the power, 2013-04-24 01:09:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14254005/6001

[commit-bot: I haz the power, 2013-04-24 01:09:39]

Presubmit check for 14254005-6001 failed and returned exit status 1.

INFO:root:Found 3 file(s).

INFO:PRESUBMIT:Skipping pylint: no matching changes.
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/build/android/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/build/android/buildbot/tests/bb_run_bot_test.py

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  build/android/gyp/apk_install.py, line 32, 92 chars \
  build/android/gyp/apk_install.py, line 33, 94 chars

Presubmit checks took 2.9s to calculate.

[cjhopman, 2013-04-24 17:17:14]

Committed patchset #3 manually as r196170.