Clarify that ClientCertStoreImpl::SelectClientCerts is testing-only

net/ssl/client_cert_store_impl_mac.cc

Index: net/ssl/client_cert_store_impl_mac.cc
diff --git a/net/ssl/client_cert_store_impl_mac.cc b/net/ssl/client_cert_store_impl_mac.cc
index e6cfeeb03925d1b41fcabc5f1b612b7a5b86a5fa..9db138103e0ee1d2dcd6f7d66ef38f7e44be18f7 100644
--- a/net/ssl/client_cert_store_impl_mac.cc
+++ b/net/ssl/client_cert_store_impl_mac.cc
@@ -247,19 +247,20 @@ bool ClientCertStoreImpl::GetClientCerts(const SSLCertRequestInfo& request,
                             selected_certs);
 }
 
-bool ClientCertStoreImpl::SelectClientCerts(const CertificateList& input_certs,
-                                            const SSLCertRequestInfo& request,
-                                            CertificateList* selected_certs) {
+bool ClientCertStoreImpl::SelectClientCertsForTesting(
+    const CertificateList& input_certs,
+    const SSLCertRequestInfo& request,
+    CertificateList* selected_certs) {
   return GetClientCertsImpl(NULL, input_certs, request, false,
                             selected_certs);
 }
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)

[wtc, 2013/04/19 23:57:11]

I think "defined(OS_MACOSX) &&" can be removed. This file is
named _mac.cc, so it is only used by Mac OS X, and possibly
iOS.

[Ryan Sleevi, 2013/04/29 22:52:18]

Originally did it for symmetry with the .h, but sure, we can drop it from here.

-bool ClientCertStoreImpl::SelectClientCertsGivenPreferred(
-      const scoped_refptr<X509Certificate>& preferred_cert,
-      const CertificateList& regular_certs,
-      const SSLCertRequestInfo& request,
-      CertificateList* selected_certs) {
+bool ClientCertStoreImpl::SelectClientCertsGivenPreferredForTesting(
+    const scoped_refptr<X509Certificate>& preferred_cert,
+    const CertificateList& regular_certs,
+    const SSLCertRequestInfo& request,
+    CertificateList* selected_certs) {
   return GetClientCertsImpl(preferred_cert, regular_certs, request, false,
                             selected_certs);
 }